cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi" <Animesh.Chaturv...@citrix.com>
Subject Re: Review Request: Typos fixed
Date Fri, 31 May 2013 00:55:58 GMT


> On April 11, 2013, 1:26 p.m., Joe Brockmeier wrote:
> > Hi - the content looks good, but the actual patch looks wonky. Doesn't apply. Can
you reformat and make sure that it applies against master? (Actually try applying it to master
as a patch, if you haven't.) Thanks!
> 
> Pascal Borreli wrote:
>     my original plan was to target 4.1 branch, are you sure you want me to rebase to
master ?
> 
> Joe Brockmeier wrote:
>     Hi Pascal, 
>     
>     Sorry, I'm still waking up! This also doesn't apply cleanly on 4.1 for me. Can you
retry?

Pascal any updates?


- Animesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10411/#review19001
-----------------------------------------------------------


On April 10, 2013, 11:06 p.m., Pascal Borreli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10411/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 11:06 p.m.)
> 
> 
> Review request for cloudstack, Joe Brockmeier and Sebastien Goasguen.
> 
> 
> Description
> -------
> 
> Few typo fixed
> 
> 
> Diffs
> -----
> 
>   docs/it-IT/hypervisor-host-install-libvirt.po a04f6c2 
>   docs/ja-JP/hypervisor-host-install-libvirt.po a0b587d 
>   docs/pot/hypervisor-host-install-libvirt.pot 6df34bb 
>   docs/pt-BR/hypervisor-host-install-libvirt.po 6aad9b7 
>   docs/zh-CN/hypervisor-host-install-libvirt.po 189be92 
>   docs/zh-TW/hypervisor-host-install-libvirt.po 3e4ae93 
>   engine/api/src/org/apache/cloudstack/engine/subsystem/api/network/NetworkSubsystem.java
53254cc 
>   engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateProfile.java
e05e7db 
>   engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
1b0661c 
>   engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java 9e04909

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
8d01eb7 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 52ea8e2 
>   server/src/com/cloud/storage/TemplateProfile.java 1d8b6bf 
> 
> Diff: https://reviews.apache.org/r/10411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pascal Borreli
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message