cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
Date Thu, 30 May 2013 17:23:53 GMT
On Thu, May 30, 2013 at 04:29:36PM +0000, Pranav Saxena wrote:
> Thanks Chip for reminding me of that . I have rebased my branch off latest master now
 and there are no conflicts . Please go ahead and have a look at the diff . 
> Please let me know in case there are any concerns.
> 
> Thanks,
> Pranav

Thanks!

I have a question, but +1 from me.

Question:

Generally, I see lots of static strings that assume en-US in the patch
(which seems to follow the existing patterns).  How are those strings
localized?  Or are they not?  

This is my first time reviewing UI code in depth, hence the question 
(I wanted to see how a feature like this was pulled together... it's a good model!).

Examples in:
ui/scripts/docs.js
ui/scripts/system.js

These include labels, error messages, dialog messages, etc...

-chip

Mime
View raw message