cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mice xia" <mice_...@tcloudcomputing.com>
Subject Re: Review Request: CLOUDSTACK-2130:UpdateDefaultNicForVirtualMachine api should also create usage events for updating new default network
Date Thu, 30 May 2013 07:28:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11511/#review21184
-----------------------------------------------------------

Ship it!


Ship It!

- mice xia


On May 29, 2013, 12:56 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11511/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 12:56 p.m.)
> 
> 
> Review request for cloudstack and mice xia.
> 
> 
> Description
> -------
> 
> The resource_name in usage_event table must refer to the NIC ID.
> Updated the Events with old NIC Id.
> 
> 
> This addresses bug CLOUDSTACK-2130.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 5657877 
> 
> Diff: https://reviews.apache.org/r/11511/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> Changed default NIC from id = 8 to 12.
> 
> select * from usage_event;
> 
> | 25 | NETWORK.OFFERING.REMOVE |          2 | 2013-05-29 12:31:58 |       1 |       
   3 | 8              |           8 |        NULL |           1 | NULL           |       
 0 |
> | 26 | NETWORK.OFFERING.ASSIGN |          2 | 2013-05-29 12:31:58 |       1 |       
   3 | 12             |           8 |        NULL |           1 | NULL           |       
 0 |
> | 27 | NETWORK.OFFERING.REMOVE |          2 | 2013-05-29 12:31:58 |       1 |       
   3 | 12             |           8 |        NULL |           0 | NULL           |       
 0 |
> | 28 | NETWORK.OFFERING.ASSIGN |          2 | 2013-05-29 12:31:58 |       1 |       
   3 | 8              |           8 |        NULL |           0 | NULL           |       
 0 |
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message