cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prachi Damle" <prachi.da...@citrix.com>
Subject Re: Review Request: Fixed CLOUDSTACK-2662 Preferred implicit dedication fails with insufficient capacity even if shared hosts are available.
Date Wed, 29 May 2013 21:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11510/#review21164
-----------------------------------------------------------


I see the check to see if a host is empty first lists all user VMs on the host and then checks
the reservation entry for system VMs. Instead of reading the reservation entry, use a list
method on vmInstanceDao (instead of userVmDao) to list all types of vms(user,router,system)
on the host.

Also this logic is different in the getPlannerUsage() method Vs the actual planner logic.
We should make both consistent.

- Prachi Damle


On May 29, 2013, 10:16 a.m., Rajesh Battala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11510/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 10:16 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prachi Damle.
> 
> 
> Description
> -------
> 
> Issues:
> In Implicit planner resource usage is fixed to "Dedicated". It should be Dedicated/Shared
depending upon the Implict Planner strict/preferred modes and hosts availability.
> 
> Fixed:
> Issue is fixed by determining the resource usage to be "Dedicated/Shared" depending upon
the Implicit strict/preferred mode and the hosts availability for the planner.
> 
> 
> This addresses bug CLOUDSTACK-2662.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/deploy/DeploymentClusterPlanner.java 1a19c71 
>   plugins/deployment-planners/implicit-dedication/src/com/cloud/deploy/ImplicitDedicationPlanner.java
d47d8f5 
>   server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 
>   server/src/com/cloud/deploy/FirstFitPlanner.java caf8c6e 
> 
> Diff: https://reviews.apache.org/r/11510/diff/
> 
> 
> Testing
> -------
> 
> Test Cases Executed Manually :
> 
> Accounts : Admin, TestA, TestB
> 2 Clusters, 3 Hosts. (HostA, HostB, HostC)
> 
> When zone is enabled. 
> In HostA , ssvm, cpvm had came up and this resource is marked as Shared.
> 
> 1. login to TestA, create Vm with implict Strict.
>    routerVm for TestA came on HostB (marked as Shared) and instance came up on HostC
( Marked as Dedicated)
> 2. from TestA, deploy a VM with implict Preffered. 
>    VM successfuly deployed on the HostC. (as its possible to deploy in strict mode, VM
got deployed on HostC)
> 3. login to TestB, 
>    Create VM with Implict Strcit.Creation of Vm failed successfuly ( as there are no
empty hosts)
>    Create VM with Implict Preferred. router VM created on HostB. Instance got deployed
on HostB. (tried Dedicated as there are no empty hosts, tired with Shared and deployed on
HostB)
>    Create VM with Implict Preferred, deployVm. instance got created on HostA.( Tried
Dedicated and then tried shared. As HostA is marked as Shared VM got deployed on HostA)
>   from TestB account two Vm's got deployed, with implict preferred mode. VM's were successfully
deployed on the Hosts which are marked as Shared.
> 4. Removed the VM's deployed from TestA and Router for the TestA.
>    HostC now unmarked as 'Dedicated'
> 5. Login to TestB, 
>    Deploy Vm with Implict preferred. VM got deployed on HostC ( tried strict as empty
HostC is available, VM deployed in HostC). HostC marked as "Dedicated"
>    Deploy Vm with Implict Strict. VM got deployed on HostC. (As dedicated host is available
because of above deployement. Vm got successfuly deployed on HostC)
> 
> 6. Login as Admin
>    deploy vm with "medium instance" offering. VM got deployed in shared resource host.
> 
> 
> Screenshots
> -----------
> 
> mysql_data_xencenter_view
>   https://reviews.apache.org/r/11510/s/26/
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message