cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object
Date Mon, 27 May 2013 12:35:59 GMT


> On May 27, 2013, 12:27 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java, line 71
> > <https://reviews.apache.org/r/11373/diff/1/?file=296466#file296466line71>
> >
> >     Can offering.getVolatileVm() be null ? If yes then we should set false.

It cannot be null as serviceofferingJoinVO is populated from service offering table and while
creating service offering entry we set to false if the isVolatile is null.


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21060
-----------------------------------------------------------


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> -------
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message