cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request: when comparing scopes, compare scope ids by value, not reference.
Date Tue, 21 May 2013 06:20:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11246/#review20824
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On May 20, 2013, 7:49 p.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11246/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 7:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> code compares Long values with == which will work for Long cached values, but not others

> 
> switched to use .equals
> 
> 
> Diffs
> -----
> 
>   engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/AbstractScope.java
c94db66 
> 
> Diff: https://reviews.apache.org/r/11246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message