cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
Date Mon, 20 May 2013 18:55:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/#review20782
-----------------------------------------------------------


Commit 8ea1601bd3a9ad04f6f0a6c03be540303d05fef8 in branch refs/heads/4.1 from Chip Childers
<chip.childers@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8ea1601 ]

CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors

Missing default constructor fails the agent manager reloading the XCP
resource on reboot of management server. This is fixed by using the
default constructor as do other Xen resources and include a new resource
ala XenServers for XCP1.6.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)

Conflicts:
	plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java

Signed-off-by: Prasanna Santhanam <tsp@apache.org>


- ASF Subversion and Git Services


On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11238/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 1:46 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
>     
>     Missing default constructor fails the agent manager reloading the XCP
>     resource on reboot of management server. This is fixed by using the
>     default constructor as do other Xen resources and include a new resource
>     ala XenServers for XCP1.6.
>     
>     Signed-off-by: Prasanna Santhanam <tsp@apache.org>
>     (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
>     
>     Conflicts:
>         plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>     
>     Signed-off-by: Prasanna Santhanam <tsp@apache.org>
> 
> 
> This addresses bug CLOUDSTACK-2554.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
04982a5 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6

>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java
PRE-CREATION 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
e4fc9ef 
> 
> Diff: https://reviews.apache.org/r/11238/diff/
> 
> 
> Testing
> -------
> 
> This was tested against the build from master with the BVT across xen 6.0.2, kvm and
xcp 1.6.
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message