cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isaac Chiang" <isaacchi...@gmail.com>
Subject Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working
Date Mon, 20 May 2013 00:59:37 GMT


> On May 17, 2013, 9:12 a.m., Devdeep Singh wrote:
> > Ship It!
> 
> Devdeep Singh wrote:
>     Changes look fine. Issac, since you are committer, you can push these changes yourself
:).

Thanks :)


- Isaac


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10479/#review20695
-----------------------------------------------------------


On May 4, 2013, 1:37 p.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10479/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 1:37 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Pranav Saxena.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1871 : domainId parameter to uploadVolume not working
> 
> 1. Remove duplicated lines for setting domainId.
> 2. Set domainId with owner's domain if the owner is specified ( with account and domainid
passed in)
> 
> 
> This addresses bug CLOUDSTACK-1871.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 1e8edaf 
> 
> Diff: https://reviews.apache.org/r/10479/diff/
> 
> 
> Testing
> -------
> 
> Test from UI and curl request, both work well
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message