cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Re: Review Request: CLOUDSTACK-2543: createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host
Date Fri, 17 May 2013 15:11:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11221/#review20701
-----------------------------------------------------------


Changes look good.
I also see a patch file in scripts/vm/hypervisor/xenserver/xcposs. This also needs to be fixed
for devcloud to work

- Koushik Das


On May 17, 2013, 1:56 p.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11221/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 1:56 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Koushik Das.
> 
> 
> Description
> -------
> 
> createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host.
> 
> 1.The directory of the scripts should be ".." rather "../../.." in all the xenser patches
file.
> Corrected the path to ".." because the scripts are located at scripts/vm/hypervisor/xenserver/xenserver56/patch
b/scripts/vm/hypervisor/xenserver/
> 
> 
> This addresses bug CLOUDSTACK-2543.
> 
> 
> Diffs
> -----
> 
>   scripts/vm/hypervisor/xenserver/xcpserver/patch a275df4 
>   scripts/vm/hypervisor/xenserver/xenserver56/patch 5c4673d 
>   scripts/vm/hypervisor/xenserver/xenserver56fp1/patch c7c58b9 
>   scripts/vm/hypervisor/xenserver/xenserver60/patch 26205f2 
> 
> Diff: https://reviews.apache.org/r/11221/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested with xenserver6.1 on master branch.
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message