cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request: Fixed Volume which is added thru upload volume is failed to attach to the instance saying Volume state must be in Allocated, Ready or in Uploaded state( Though uploaded Volume state is uploaded)
Date Fri, 17 May 2013 09:50:34 GMT


> On May 17, 2013, 9:44 a.m., Devdeep Singh wrote:
> > Ship It!

Committed the changes to master. Kindly close this request.


- Devdeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11022/#review20698
-----------------------------------------------------------


On May 9, 2013, 12:49 p.m., Rajesh Battala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11022/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 12:49 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Description
> -------
> 
> When user uploads the volume, successful uploaded volume state in DB is still marked
as "UploadOp"
> 
> This is issue with the VolumeServiceImpl, after uploaded operation is successful it should
call the stateTransit  "UploadOp" to "Uploaded".
> Issue is fixed by call the volume state change and now the volume is moved to "uploaded"
state which will not throw the exception as the volume is not in ready state.
> 
> 
> This addresses bug CLOUDSTACK-2081.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
b39502b 
> 
> Diff: https://reviews.apache.org/r/11022/diff/
> 
> 
> Testing
> -------
> 
> Unittests are running successful.
> 
> 1. Uploaded the volume, verified the state column in db. during uploading progress its
is "UploadOp" after upload is successful it is moved to "Uploaded"
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message