cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-1901: API:MS: DeleteEvents deletes Archived events as well
Date Fri, 17 May 2013 08:47:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11177/#review20692
-----------------------------------------------------------


AlertDao also has getLastAlert routines. Shouldn't the archived alerts be filtered from them
too? Same comments applies to EventDao. It too has listOlderEvents and findCompletedEvent
apis. Should archived events be filtered there too?

- Devdeep Singh


On May 15, 2013, 10:24 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11177/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 10:24 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1901: API:MS: DeleteEvents deletes Archived events as well
> 
> 
> This addresses bug CLOUDSTACK-1901.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/alert/dao/AlertDaoImpl.java 4b9bc6a 
>   engine/schema/src/com/cloud/event/dao/EventDaoImpl.java 0d3d38a 
> 
> Diff: https://reviews.apache.org/r/11177/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 1. Archive some events (these events will not appear in the listEvents call).
> 2. Delete events by type of olderthan.
> 3. Observed that the archived events are still there in DB.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message