cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.
Date Thu, 16 May 2013 21:45:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/
-----------------------------------------------------------

(Updated May 16, 2013, 9:45 p.m.)


Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh Chodapuneedi, Kelven Yang,
and Animesh Chaturvedi.


Changes
-------

This is the latest PVLAN diff for vmware deployments on cloudstack. I run into the error "error:
short SHA1 01a0384 is ambiguous. fatal: Not a valid object name 01a0384" when trying to update
the diff. Looks like git is running into collisions with the SHA1 checksum of its commits
between local and remote branches. Generating the patch in a clean new workspace did not fix
this issue. I am not sure how to overcome this.

Please let me know if you are unable to apply this patch. You should be able to do a git apply
at the least - please copy over the commit authorship from this patch and sign off on the
patch.


Description
-------

Please find attached the diffs for pvlan support for vmware DVSwitch deployments on cloudstack.
You will find two diffs - the parent diff is Sateesh's fix for CLOUSTACK-2316 which is needed
to be cherry-picked on the pvlan branch from the master. The other diff contains the changes
for pvlan support.

These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 1000v distributed
virtual switch.


This addresses bug CLOUDSTACK-1456.


Diffs
-----

  api/src/com/cloud/agent/api/PlugNicCommand.java b896e45 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java bdfac06 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 7f323c5 

Diff: https://reviews.apache.org/r/11019/diff/


Testing
-------

The code has been tested on the Vmware DVSwitch for advanced shared networks on vmware cluster
deployments on cloudstack. Unit tests will be the same as those provided by Sheng as part
of the overall PVLAN support for XenServer and KVM, and will exercise the vmware pvlan code
path when user VMs are created with vNICs sitting on advanced shared networks that have the
optional Private VLAN value set during their creation. VM live migration using vmware vMotion
has also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message