cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request: Midonet Plugin Update
Date Wed, 15 May 2013 15:08:50 GMT


> On May 15, 2013, 3:06 p.m., Hugo Trippaers wrote:
> > Ship It!

commit 987c3427dd26f36a060571d022efb7043d0ee473
Author: Joe Mills <joe@midokura.jp>
Date:   Wed May 15 17:47:58 2013 +0900

    Midonet Plugin bugfixes

    * Updated SQL upgrade scripts to include midonet configs.
    * Fixed bug where default ICMP allow rule was missing
      on static NAT creation, keeping VMs from being able
      to ping the gateway.
    * Changed the filter in the MidoNetElement callbacks to allow
      calls when Midonet is configured.

    Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11174/#review20592
-----------------------------------------------------------


On May 15, 2013, 9:11 a.m., joe mills wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11174/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 9:11 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
> Midonet Plugin Update
> 
> * Updated SQL upgrade script to include midonet configs.
> * Fixed bug where default ICMP allow rule was missing
>   on static NAT creation, keeping VMs from being able
>   to ping the gateway.
> * Changed the filter in the MidoNetElement callbacks to allow
>   calls when Midonet is configured.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java
d07fa56 
>   plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java
20b74b9 
>   plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetPublicNetworkGuru.java
7e93edb 
>   plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java
aec9c2d 
>   setup/db/db/schema-410to420.sql 9e1a871 
> 
> Diff: https://reviews.apache.org/r/11174/diff/
> 
> 
> Testing
> -------
> 
> Deployed MIDO topology and tested static NAT with gateway ping.
> Deployed VirtualRouter network and tested static NAT with gateway ping.
> 
> 
> Thanks,
> 
> joe mills
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message