cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayapal Reddy" <jayapalreddy.ur...@citrix.com>
Subject Re: Review Request: ACL on private gateway feature
Date Mon, 13 May 2013 13:14:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10942/
-----------------------------------------------------------

(Updated May 13, 2013, 1:14 p.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali Reddy.


Changes
-------

Updated review comments


Description
-------

ACL on private gateway feature.
ACLs are implemented with the container model


This addresses bug CLOUDSTACK-768.


Diffs (updated)
-----

  api/src/com/cloud/network/NetworkService.java 4a6a84f 
  api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 
  api/src/com/cloud/network/vpc/NetworkACLService.java 0258333 
  api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 
  api/src/com/cloud/network/vpc/VpcService.java 23e2764 
  api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695

  api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java b8abc78

  api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062 
  core/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java db50f3f 
  engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 
  engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f 
  engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 
  patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CREATION 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
8fe8c88 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
7ce3b93 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 9f6a9f0

  server/src/com/cloud/api/ApiResponseHelper.java 7b2bb03 
  server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a 
  server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 306b1a8 
  server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java dbfd88c 
  server/src/com/cloud/network/vpc/NetworkACLManager.java 0ff3e88 
  server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 71d6da4 
  server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 7c50d90 
  server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java b70ede8 
  server/test/com/cloud/vpc/MockVpcManagerImpl.java 3835c2e 
  server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java 0f12c43 
  server/test/com/cloud/vpc/NetworkACLManagerTest.java dc53b2b 
  server/test/com/cloud/vpc/NetworkACLServiceTest.java 145efb4 
  server/test/org/apache/cloudstack/privategw/AclOnPrivateGwTest.java PRE-CREATION 
  setup/db/db/schema-410to420.sql 136d61b 
  test/integration/smoke/test_network_acl.py 300fff9 
  test/integration/smoke/test_privategw_acl.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10942/diff/


Testing
-------

1. Tested creation of private gateway with acl id
2. replacenetworkacl for privategateway id
3. add new acl item and checking the applying item on private gw
4. restart router and see the rules are added or not.


Thanks,

Jayapal Reddy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message