cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: [MERGE] PVLAN branch to MASTER
Date Sat, 11 May 2013 17:35:32 GMT
On Thu, May 09, 2013 at 11:39:00AM -0700, Sheng Yang wrote:
> On Wed, May 8, 2013 at 4:32 PM, Chip Childers <chip.childers@sungard.com>wrote:
> 
> > On Wed, May 08, 2013 at 04:25:31PM -0700, Sheng Yang wrote:
> > > FS at:
> > >
> > https://cwiki.apache.org/CLOUDSTACK/pvlan-for-isolation-within-a-vlan.html
> > >
> > > PVLAN branch has been under development for some time, and now the
> > > functionality works on KVM and Xen, would be followed by VMware soon
> > >
> > > VM live migration is not supported so far, I am waiting for the fix of
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-1638 .
> > >
> > > We're using ovs/open flow to manipulate ingress/egress traffic to emulate
> > > the isolation PVLAN function on KVM and Xen. The details are in the FS.
> > >
> > > The core code change is minimal and there is no DB change, because we
> > took
> > > advantage of "broadcast domain" to introduce "pvlan://" broadcast URI to
> > > describe the primary and isolated PVLAN for the network.
> > >
> > > If there is no objection, I would merge the branch in 48 hours.
> > >
> > > Thanks.
> > >
> > > --Sheng
> >
> > Hey Sheng,
> >
> > Recently, merge requests have included things like:
> >
> > * Did you check the branch's RAT execution success?
> >
> 
> Would check that.

Thanks!

> 
> 
> > * Are there new dependencies introduced?
> >
> 
> No.

Great - Thanks for answering!

> 
> 
> > * What automated testing (unit and integration) is included in the new
> > feature?
> 
> * What testing has been done to check for potential regressions?
> >
> 
> Still working on testing part. Guess I would need to get it done before
> another merge request.

Please.  We've agreed that new features need automation and testing
prior to merging.

Thanks Sheng!

> 
> 
> >
> > Some of these might be easily answered, but they're what we've agreed
> > are the key elements of a feature merge request.
> >
> 
> Thanks.
> 
> --Sheng
> 
> >
> > -chip
> >

Mime
View raw message