cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sheng Yang" <sh...@yasker.org>
Subject Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.
Date Fri, 10 May 2013 21:58:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/#review20434
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/11019/#comment42102>

    I meant, if you get the command executed in vmware resources, then you won't need hypervisor
specify lines here.



server/src/com/cloud/vm/VirtualMachineManagerImpl.java
<https://reviews.apache.org/r/11019/#comment42103>

    Still here.


- Sheng Yang


On May 10, 2013, 2:32 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11019/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 2:32 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh Chodapuneedi, Kelven
Yang, and Animesh Chaturvedi.
> 
> 
> Description
> -------
> 
> Please find attached the diffs for pvlan support for vmware DVSwitch deployments on cloudstack.
You will find two diffs - the parent diff is Sateesh's fix for CLOUSTACK-2316 which is needed
to be cherry-picked on the pvlan branch from the master. The other diff contains the changes
for pvlan support.
> 
> These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 1000v distributed
virtual switch.
> 
> 
> This addresses bug CLOUDSTACK-1456.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
99ad1ca 
>   server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
>   server/src/com/cloud/network/NetworkModelImpl.java bd62886 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 247be2a

>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 7f323c5 
> 
> Diff: https://reviews.apache.org/r/11019/diff/
> 
> 
> Testing
> -------
> 
> The code has been tested on the Vmware DVSwitch for advanced shared networks on vmware
cluster deployments on cloudstack. Unit tests will be the same as those provided by Sheng
as part of the overall PVLAN support for XenServer and KVM, and will exercise the vmware pvlan
code path when user VMs are created with vNICs sitting on advanced shared networks that have
the optional Private VLAN value set during their creation. VM live migration using vmware
vMotion has also been tested with these changes on vmware and it works as expected.
> 
> Further testing will be carried out and this review request will be updated accordingly.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message