cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <>
Subject Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
Date Fri, 10 May 2013 11:18:12 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 10, 2013, 11:18 a.m.)

Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Cloudstack-702. Multiple ip ranges in different subnets. 

This feature enables adding of guest ip ranges (public ips)  form different subnets.

In order to provide the dhcp service to a different subnet we create an ipalias on the router.
This allows the router to listen to the dhcp request from the guest vms and respond accordingly.
Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack
uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the
new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file,
this file replaces the old config in the router. 

The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new
subnet is added one of the ip from the subnet is used to configure the ip alias. 

I have pushed the code to ,
also rebased the code with master. 
I need to test the code for advanced sg enabled network using kvm.

This is duplicate of the pervious review request please
ignore it. 

I have added the unit test

Also accomodated some of the changes suggested by koushik. 
corrected the import statements. renamed the IpAlias command to createIpAlias command. 

This addresses bug Cloudstack-702.

Diffs (updated)

  api/src/com/cloud/agent/api/to/ PRE-CREATION 
  api/src/com/cloud/exception/ PRE-CREATION 
  api/src/com/cloud/network/element/ f73590c 
  api/src/com/cloud/vm/ PRE-CREATION 
  client/tomcatconf/ 36f232c 
  core/src/com/cloud/agent/api/routing/ PRE-CREATION 
  core/src/com/cloud/agent/api/routing/ PRE-CREATION 
  core/src/com/cloud/agent/api/routing/ PRE-CREATION 
  core/src/com/cloud/agent/api/routing/ PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/ b9bda4d 
  core/src/com/cloud/network/ PRE-CREATION 
  engine/schema/src/com/cloud/dc/dao/ cc82632 
  engine/schema/src/com/cloud/dc/dao/ 100295b 
  engine/schema/src/com/cloud/network/dao/ 3d588fa 
  engine/schema/src/com/cloud/network/dao/ 73f310f 
  engine/schema/src/com/cloud/vm/dao/ 67c1e07 
  engine/schema/src/com/cloud/vm/dao/ c70d194 
  patches/systemvm/debian/config/root/ PRE-CREATION 
  patches/systemvm/debian/config/root/ PRE-CREATION 
  patches/systemvm/debian/config/root/ PRE-CREATION 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/ bac361d

  plugins/network-elements/midonet/src/com/cloud/network/element/ 804e4a6

  scripts/vm/hypervisor/xenserver/ PRE-CREATION 
  scripts/vm/hypervisor/xenserver/ PRE-CREATION 
  scripts/vm/hypervisor/xenserver/vmops 30b5300 
  scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f 
  scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 
  server/src/com/cloud/configuration/ bce1776 
  server/src/com/cloud/configuration/ 37ca793 
  server/src/com/cloud/network/ 4af716c 
  server/src/com/cloud/network/ 4fffbc1 
  server/src/com/cloud/network/addr/ 25e9d30 
  server/src/com/cloud/network/element/ f601f4f 
  server/src/com/cloud/network/router/ f49ab79 
  server/src/com/cloud/network/router/ 6620e0a 
  server/src/com/cloud/vm/dao/ PRE-CREATION 
  server/src/com/cloud/vm/dao/ PRE-CREATION 
  server/src/com/cloud/vm/dao/ PRE-CREATION 
  server/test/com/cloud/configuration/ PRE-CREATION 
  server/test/com/cloud/network/ 2f717c8 
  server/test/com/cloud/vpc/ 83b1924 
  server/test/com/cloud/vpc/ f884ba1 
  server/test/com/cloud/vpc/ ef5478b 
  setup/db/db/schema-410to420.sql c8ac1ec 



Tested this with xenserver in basic zone.


bharat kumar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message