cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Review Request: PVLAN support for vmware Distributed Virtual switch deployments on cloudstack
Date Thu, 09 May 2013 02:08:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11018/
-----------------------------------------------------------

Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, and Kelven Yang.


Description
-------

Please find attached the diffs for pvlan support for vmware DVSwitch deployments on cloudstack.
You will find two diffs - the parent diff is Sateesh's fix for CLOUSTACK-2316 which is needed
to be cherry-picked on the pvlan branch from the master. The other diff contains the changes
for pvlan support.


This addresses bug CLOUDSTACK-1456.


Diffs
-----

  engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
25e7423 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java 0a3e20b 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 7f323c5 

Diff: https://reviews.apache.org/r/11018/diff/


Testing
-------

The code has been tested on the Vmware DVSwitch for advanced shared networks on vmware cluster
deployments on cloudstack. Unit tests will be the same as those provided by Sheng as part
of the overall PVLAN support for XenServer and KVM, and will exercise the vmware pvlan code
path when user VMs are created with vNICs sitting on advanced shared networks that have the
optional Private VLAN value set during their creation. VM live migration using vmware vMotion
has also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message