cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Radhika PC" <radhika.puthiyet...@citrix.com>
Subject Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]
Date Tue, 07 May 2013 05:44:52 GMT


> On April 30, 2013, 8:01 a.m., Jessica Tomechak wrote:
> > docs/en-US/plugin-midonet-preparations.xml, line 40
> > <https://reviews.apache.org/r/10136/diff/4/?file=286089#file286089line40>
> >
> >     Believe the DTD requires a <para> tag within each entry tag. Like <entry><para>Setting
Name</para></entry>. The same comment applies throughout the doc here.
> 
> Dave Cahill wrote:
>     Wouldn't Publican fail to build on DTD errors?
>     
>     Running this command successfully builds the doc for me:
>     publican build --config=publican-plugin-midonet.cfg --langs=en-US --format=pdf
> 
> Dave Cahill wrote:
>     The DocBook  site also shows this as an example of a legal entry (no para):
>     <entry>3.1415927</entry>
>     
>     ref: http://www.docbook.org/tdg/en/html/entry.html
> 
> Radhika PC wrote:
>     Across the CloudStack doc, we use a block element, such as <para> element within
a <entry> element. This is for using a list in a table entry, along with some text outside
the list.

Hi Dave,

I tried to apply the patch, and I get the following error. 

Applying: Add docs for MidoNet networking plugin [CLOUDSTACK-996]
error: docs/en-US/MidoNet_Plugin_Guide.ent: already exists in index
error: docs/en-US/MidoNet_Plugin_Guide.xml: already exists in index
error: docs/en-US/plugin-midonet-about.xml: already exists in index
error: docs/en-US/plugin-midonet-features.xml: already exists in index
error: docs/en-US/plugin-midonet-introduction.xml: already exists in index
error: docs/en-US/plugin-midonet-preparations.xml: already exists in index
error: docs/en-US/plugin-midonet-provider.xml: already exists in index
error: docs/en-US/plugin-midonet-revisions.xml: already exists in index
error: docs/en-US/plugin-midonet-ui.xml: already exists in index
error: docs/en-US/plugin-midonet-usage.xml: already exists in index
error: docs/publican-plugin-midonet.cfg: already exists in index
Patch failed at 0001 Add docs for MidoNet networking plugin [CLOUDSTACK-996]
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

Looks like the patch needed to be created again.. extremely sorry for missing this request.
As soon as you submit a patch, please do notify the reviewers by sending a direct mail for
a quick response. I tried this method for my patches, and it did work.


- Radhika


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10136/#review19943
-----------------------------------------------------------


On April 30, 2013, 5:22 a.m., Dave Cahill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10136/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 5:22 a.m.)
> 
> 
> Review request for cloudstack and Radhika PC.
> 
> 
> Description
> -------
> 
> Adding docs for MidoNet networking plugin [CLOUDSTACK-996]
> 
> Plugin itself is awaiting review / commit here:
> [PATCH 1] https://reviews.apache.org/r/9897/
> [PATCH 2] https://reviews.apache.org/r/9898/
> 
> 
> This addresses bug CLOUDSTACK-996.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/MidoNet_Plugin_Guide.ent PRE-CREATION 
>   docs/en-US/MidoNet_Plugin_Guide.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-about.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-features.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-introduction.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-preparations.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-provider.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-revisions.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-ui.xml PRE-CREATION 
>   docs/en-US/plugin-midonet-usage.xml PRE-CREATION 
>   docs/publican-plugin-midonet.cfg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10136/diff/
> 
> 
> Testing
> -------
> 
> Built docs.
> 
> 
> Thanks,
> 
> Dave Cahill
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message