cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zhou" <w.z...@leaseweb.com>
Subject Review Request: (CLOUDSTACK-2319) fix "unable to add egress rules" in SecurityGroup
Date Mon, 06 May 2013 18:44:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

This patch changes:
(1) CloudStack UI (egress rule in Security Group)
(2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid)
instead of security_group.id (find by security_group.uuid)


This addresses bug CLOUDSTACK-2319.


Diffs
-----

  api/src/com/cloud/network/security/SecurityGroupRules.java d255e46 
  core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef 
  server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05 
  ui/scripts/network.js 1bc4eba 

Diff: https://reviews.apache.org/r/10957/diff/


Testing
-------

Testing ok.


Thanks,

Wei Zhou


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message