cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider
Date Mon, 06 May 2013 15:36:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20191
-----------------------------------------------------------



plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
<https://reviews.apache.org/r/10858/#comment41413>

    implement and shutdown need to be implemented? how would VLAN be configured on NetScaler
with out implementing network?



plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
<https://reviews.apache.org/r/10858/#comment41414>

    remove the TODO's, if there is no  need for method implementation and just return true



server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10858/#comment41422>

    same should hold for other external devices as well. so please put generic comment (with
out netscaler)


- Murali Reddy


On April 30, 2013, 3:28 a.m., Rajesh Battala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 3:28 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena Prokharchyk, Vijay
Venkatachalam, and Ram Ganesh.
> 
> 
> Description
> -------
> 
> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with all the services
provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
>   plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
2bbdb04 
>   server/src/com/cloud/network/NetworkServiceImpl.java 2dcb47d 
>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/test/com/cloud/vpc/ChildTestConfiguration.java PRE-CREATION 
>   server/test/com/cloud/vpc/VpcManagerTest.java PRE-CREATION 
>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java cbb6c00

>   server/test/resources/VpcContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10858/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing:
> ==============
> 1. Creation of Vpc with the default offering with NS is created successfully. ( Enable
Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfully.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider with dedicated
mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider with shared mode
should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is created successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. 
> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier cidr range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netscaler device and
necessary configuration is created and LB rule is created on NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is cleared
> 20. Deletion of tier will mark the netscaler to be in free mode.
> 
> 
> Unit Test:
> ===========
> Created VpcManger tests and added few tests to createNetworkOfferingTest
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message