cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Saxena" <pranav.sax...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-2178 : "Add guest network" button is not responding
Date Sat, 04 May 2013 20:48:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/#review20169
-----------------------------------------------------------


Review comment on the corresponding JIRA ticket to verify if its actually a valid bug . If
yes , then we'll definitely proceed with validating the fix . Thanks !

- Pranav Saxena


On May 1, 2013, 3:49 p.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10882/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 3:49 p.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> The root cause of the issue is that the makeForm function in dialog.js cannot work with
dependsOn field correctly.
> 
> Changed :
> 1. Dialog.js     : Modify makeForm function in Dialog.js to work correctly with "dependsOn"
field.
> 2. Network.js : Add checking for response in the call back function.
> 
> 
> This addresses bug CLOUDSTACK-2178.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/network.js 9ba725a 
>   ui/scripts/ui/dialog.js bb372fb 
> 
> Diff: https://reviews.apache.org/r/10882/diff/
> 
> 
> Testing
> -------
> 
> Test from ui ans work well
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message