cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: CLOUDSTACK-2274 : The detail view doesn't recover from loading status when trying to delete a zone with physical network on it
Date Sat, 04 May 2013 19:46:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10860/#review20165
-----------------------------------------------------------


Commit 5811ae7e2571380ab2b2be4e64686ff3affb7364 in branch refs/heads/master from Pranav Saxena
<pranav.saxena@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811ae7 ]

CLOUDSTACK-2274:Detail view loading problem when deleting a zone


- ASF Subversion and Git Services


On April 30, 2013, 7:43 a.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10860/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 7:43 a.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> According to CS' fronend logic, there is a general error handling function in cloudStack.js
line 95. Hense this is a common issue for detail view when a request failed from server.
> This patch try not to against current UI logic and provide a statusCode callback to capture
failed request. The added callback will remove loading div from detailView.
> This patch is a suggested solution to the issue.
> 
> Thanks
> 
> 
> This addresses bug CLOUDSTACK-2274.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/system.js 7aa0566 
> 
> Diff: https://reviews.apache.org/r/10860/diff/
> 
> 
> Testing
> -------
> 
> Test from UI and work well
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message