cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Saxena" <pranav.sax...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-2132 : The reload button doesn't work with Security Groups and Statistic tab in instance detail view
Date Sat, 04 May 2013 08:02:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10751/#review20158
-----------------------------------------------------------

Ship it!


The problem was that the API call was not invoked (since UI did not trigger it)when clicking
the Refresh button . The patch looks good and works . I'll merge it with master . Thanks Isaac
for the patch .Good catch ! 


- Pranav Saxena


On April 24, 2013, 7:31 a.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10751/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 7:31 a.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> The reload button for security group tab and statistic tab doesn't actually send a request
to the back-end but use the data when the user clicking into the instances detail view.
> The patch fix the issue that request to the server and replace the associated tab with
lately returned data.
> 
> 
> This addresses bug CLOUSTACK-2132.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/instances.js 3a43c60 
> 
> Diff: https://reviews.apache.org/r/10751/diff/
> 
> 
> Testing
> -------
> 
> Test from UI and work as expect.
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message