cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isaac Chiang" <isaacchi...@gmail.com>
Subject Review Request: CLOUDSTACK-2178 : "Add guest network" button is not responding
Date Wed, 01 May 2013 15:49:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/
-----------------------------------------------------------

Review request for cloudstack and Pranav Saxena.


Description
-------

The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn
field correctly.

Changed :
1. Dialog.js     : Modify makeForm function in Dialog.js to work correctly with "dependsOn"
field.
2. Network.js : Add checking for response in the call back function.


This addresses bug CLOUDSTACK-2178.


Diffs
-----

  ui/scripts/network.js 9ba725a 
  ui/scripts/ui/dialog.js bb372fb 

Diff: https://reviews.apache.org/r/10882/diff/


Testing
-------

Test from ui ans work well


Thanks,

Isaac Chiang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message