Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D227310BFA for ; Fri, 12 Apr 2013 16:59:58 +0000 (UTC) Received: (qmail 37090 invoked by uid 500); 12 Apr 2013 16:59:58 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 37056 invoked by uid 500); 12 Apr 2013 16:59:58 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 37048 invoked by uid 99); 12 Apr 2013 16:59:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2013 16:59:58 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of koushik.das@citrix.com designates 203.166.19.134 as permitted sender) Received: from [203.166.19.134] (HELO SMTP.CITRIX.COM.AU) (203.166.19.134) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2013 16:59:51 +0000 X-IronPort-AV: E=Sophos;i="4.87,464,1363132800"; d="scan'208";a="1987172" Received: from sinpex01cl01.citrite.net ([10.151.46.32]) by SYDPIPO01.CITRIX.COM.AU with ESMTP/TLS/AES128-SHA; 12 Apr 2013 16:59:28 +0000 Received: from SINPEX01CL02.citrite.net ([169.254.2.148]) by SINPEX01CL01.citrite.net ([169.254.1.252]) with mapi id 14.02.0342.003; Sat, 13 Apr 2013 00:59:27 +0800 From: Koushik Das To: "dev@cloudstack.apache.org" Subject: RE: [MERGE] ASA 1000v as external firewall in isolated guest networks Thread-Topic: [MERGE] ASA 1000v as external firewall in isolated guest networks Thread-Index: Ac40RY1aNYZMU1UnTCKhDSFGOFo3kgCVD8yAACsiCCD//+5HgIAAAXoAgAAIRoD//0r7cA== Date: Fri, 12 Apr 2013 16:59:26 +0000 Message-ID: References: <20130411174903.GE27177@USLT-205755.sungardas.corp> <20130412132039.GF41043@USLT-205755.sungardas.corp> <20130412132556.GA16282@cloud-2.local> <20130412135533.GI41043@USLT-205755.sungardas.corp> In-Reply-To: <20130412135533.GI41043@USLT-205755.sungardas.corp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.2.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org > -----Original Message----- > From: Chip Childers [mailto:chip.childers@sungard.com] > Sent: Friday, April 12, 2013 7:27 PM > To: dev@cloudstack.apache.org > Subject: Re: [MERGE] ASA 1000v as external firewall in isolated guest > networks >=20 > On Fri, Apr 12, 2013 at 06:55:56PM +0530, Prasanna Santhanam wrote: > > On Fri, Apr 12, 2013 at 09:20:39AM -0400, Chip Childers wrote: > > > On Fri, Apr 12, 2013 at 06:39:29AM +0000, Koushik Das wrote: > > > > Currently there are no functional tests, did e2e tests manually. > > > > There are some external setup that is required which then needs to = be > added to Cloudstack like Nexus 1000v, VNMC, ASA 1000v appliance details. = I > don't see any existing tests related to Vmware/Nexus stuff which I can > reuse, so implementing all these steps would need some time. > > > > > > > > So wanted to check if it is ok to merge now and add the functional = tests > subsequently? > > > > > > Before we merge it in, can we first discuss how we want to hand this > > > sort of thing? It seems that at least a marvin test, not run by > > > default, would be helpful here. Certainly documentation on how to > > > setup an environment to support the test is also needed. > > > > > > Do other's have thoughts on this? > > > > +1 - I can spare some hardware to host virtual instances of the ASA > > appliance. We do NetScaler VPXs in this fashion. But I'm not sure what > > kind of pre-programming will be required on the ASA to run the test. > > So some documentation would certainly help. >=20 > Koushik, >=20 > I think that it will require working with Prasanna to get a Marvin test s= uite for > the feature ready to go. I'd personally like to see that > *prior* to the merge into master. We need to "up our game" on automated > testing of new features, so that we stop digging ourselves deeper and > deeper into a hole. Sure will work with Prasanna on this. Ideally I would like to write tests for network offering creation with VNMC= as provider and the newly added APIs for this feature and would like to re= use existing code for testing the following features: - Vmware cluster setup with Nexus 1000v - Network creation - Vm deployment - Acquiring public IP - Static nat/pf rule creation Any help on the above would be appreciated. >=20 > -chip