Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (nike.apache.org: domain of kelven.yang@citrix.com
 designates 66.165.176.89 as permitted sender)
From: Kelven Yang <kelven.yang@citrix.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>, Hugo Trippaers
	<HTrippaers@schubergphilis.com>, Chip Childers <chip.childers@sungard.com>
Date: Fri, 5 Apr 2013 10:53:26 -0700
Subject: Re: Review Request: Finalize
 componentContext.xml/nonComponentContext.xml content organization to be
 plugin friendly
Thread-Topic: Review Request: Finalize
 componentContext.xml/nonComponentContext.xml content organization to be
 plugin friendly
Thread-Index: Ac4yJnpEyH8HCd19RcWcqM7vpOxnmA==
Message-ID: <CD845D4C.3C030%kelven.yang@citrix.com>
In-Reply-To: <CD845BC7.3C027%kelven.yang@citrix.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.3.120616
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Never mind, I found it in master.

Chip, I'll put another patch to the same review ticket.

Kelven

On 4/5/13 10:47 AM, "Kelven Yang" <kelven.yang@citrix.com> wrote:

>For some reason, the diff in the ticket about your change does not show up
>Nicira, MidoNet Network Guru.
>On quick question to confirm, Nicira/MidoNet are supposed to be available
>in non-OSS build, is that correct?
>
>Kelven
>
>On 4/5/13 5:35 AM, "Hugo Trippaers" <HTrippaers@schubergphilis.com> wrote:
>
>>Hey Kelven,
>>
>>I commented on your patch on the review board. Can you modify the patch
>>so all Nicira and MidoNet stuff is also in? I fixed master so you should
>>be able to use that.
>>
>>Cheers,
>>
>>Hugo
>>
>>> -----Original Message-----
>>> From: Kelven Yang [mailto:noreply@reviews.apache.org] On Behalf Of
>>> Kelven Yang
>>> Sent: vrijdag 5 april 2013 0:14
>>> To: Chip Childers
>>> Cc: cloudstack; Kelven Yang
>>> Subject: Review Request: Finalize
>>> componentContext.xml/nonComponentContext.xml content organization to
>>> be plugin friendly
>>>=20
>>>=20
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/10292/
>>> -----------------------------------------------------------
>>>=20
>>> Review request for cloudstack and Chip Childers.
>>>=20
>>>=20
>>> Description
>>> -------
>>>=20
>>> With removal of component auto-scanning, all components are needed to
>>> configure in XML files. For OSS deployment, component declarations will
>>>be
>>> in applicationContext.xml and componentContext.xml, for non-OSS
>>> deployment, component declarations will be in applicationContext.xml
>>>and
>>> nonossComponentContext.xml
>>>=20
>>> OSS/non-OSS common components should all go to applicationContext.xml,
>>> OSS or non-OSS specific components, or if there are OSS or non-OSS
>>>specific
>>> adapter configurations, they should go to componentContext.xml or
>>> nonComponentContext.xml respecitively.
>>>=20
>>> If you add a big feature module, organize all components for the module
>>>into
>>> its own section.
>>>=20
>>>=20
>>> This addresses bug CLOUDSTACK-1917.
>>>=20
>>>=20
>>> Diffs
>>> -----
>>>=20
>>>   client/tomcatconf/applicationContext.xml.in 17725f0
>>>   client/tomcatconf/componentContext.xml.in 2a4a29f
>>>   client/tomcatconf/nonossComponentContext.xml.in 13004c3
>>>   utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION
>>>=20
>>> Diff: https://reviews.apache.org/r/10292/diff/
>>>=20
>>>=20
>>> Testing
>>> -------
>>>=20
>>> manual test is done for both OSS/non-OSS
>>>=20
>>>=20
>>> Thanks,
>>>=20
>>> Kelven Yang
>>
>