Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B1D0F1B6 for ; Fri, 26 Apr 2013 11:36:32 +0000 (UTC) Received: (qmail 46241 invoked by uid 500); 26 Apr 2013 11:36:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 46201 invoked by uid 500); 26 Apr 2013 11:36:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 46190 invoked by uid 500); 26 Apr 2013 11:36:31 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 46181 invoked by uid 99); 26 Apr 2013 11:36:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Apr 2013 11:36:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7F14B1C91AB; Fri, 26 Apr 2013 11:36:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2731002557186936422==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public IP" changes happend in EIP enabled Zone From: "SrikanteswaraRao Talluri" To: "Prasanna Santhanam" , "SrikanteswaraRao Talluri" , "Girish Shilamkar" Cc: "cloudstack" , "venkata swamy babu budumuru" Date: Fri, 26 Apr 2013 11:36:28 -0000 Message-ID: <20130426113628.22548.2084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "SrikanteswaraRao Talluri" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10776/ X-Sender: "SrikanteswaraRao Talluri" References: <20130425144028.22548.17031@reviews.apache.org> In-Reply-To: <20130425144028.22548.17031@reviews.apache.org> Reply-To: "SrikanteswaraRao Talluri" --===============2731002557186936422== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10776/#review19765 ----------------------------------------------------------- test/integration/component/test_eip_optional_publicip.py add some detail to reflect that these tests are written for optional pu= blic enhancement and remove Load Balancing part test/integration/component/test_eip_optional_publicip.py same as above comment test/integration/component/test_eip_optional_publicip.py you might not need this 'lbrule' info as you are not using it anywhere test/integration/component/test_eip_optional_publicip.py remove this comment test/integration/component/test_eip_optional_publicip.py remove this comment test/integration/component/test_eip_optional_publicip.py remove this - SrikanteswaraRao Talluri On April 25, 2013, 2:40 p.m., venkata swamy babu budumuru wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10776/ > ----------------------------------------------------------- > = > (Updated April 25, 2013, 2:40 p.m.) > = > = > Review request for cloudstack, Prasanna Santhanam, SrikanteswaraRao Tallu= ri, and Girish Shilamkar. > = > = > Description > ------- > = > CLOUDSTACK-2191: Added the following to tests to qualify "Optional Pu= blic IP" changes happend in EIP enabled Zone > 1. Verify that the EIP zone is created with "AssociatePublicIp" capab= ility set to "false" > 2. Verify that VM doesn't get public ip by default after deployVirtua= lMachine > 3. Eanble static NAT and verify EIP semantics > 4. disable static NAT and verify EIP semantics > = > = > This addresses bug CLOUDSTACK-2191. > = > = > Diffs > ----- > = > test/integration/component/test_eip_optional_publicip.py PRE-CREATION = > = > Diff: https://reviews.apache.org/r/10776/diff/ > = > = > Testing > ------- > = > Encountered few bugs while doing pilot run of the suite hence, couldn't t= est it completely. > = > Bugs encountered during the run are : > = > CLOUDSTACK-2193 https://issues.apache.org/jira/browse/CLOUDSTACK-2193 > CLOUDSTACK-2192 https://issues.apache.org/jira/browse/CLOUDSTACK-2192 > = > = > Thanks, > = > venkata swamy babu budumuru > = > --===============2731002557186936422==--