Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD322F0BF for ; Fri, 26 Apr 2013 03:37:17 +0000 (UTC) Received: (qmail 65731 invoked by uid 500); 26 Apr 2013 03:37:17 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 65498 invoked by uid 500); 26 Apr 2013 03:37:13 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 65456 invoked by uid 500); 26 Apr 2013 03:37:11 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 65436 invoked by uid 99); 26 Apr 2013 03:37:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Apr 2013 03:37:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8BFED1C914F; Fri, 26 Apr 2013 03:37:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4331300492495442145==" MIME-Version: 1.0 Subject: Re: Review Request: Adding more Granular Global Parameters From: "Harikrishna Patnala" To: "Kishan Kavala" , "Abhinandan Prateek" , "Nitin Mehta" Cc: "cloudstack" , "Harikrishna Patnala" Date: Fri, 26 Apr 2013 03:37:07 -0000 Message-ID: <20130426033707.22548.77894@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Harikrishna Patnala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10740/ X-Sender: "Harikrishna Patnala" References: <20130423212930.22548.30986@reviews.apache.org> In-Reply-To: <20130423212930.22548.30986@reviews.apache.org> Reply-To: "Harikrishna Patnala" --===============4331300492495442145== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/ ----------------------------------------------------------- (Updated April 26, 2013, 3:37 a.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin= Mehta. Changes ------- Updated patch after changing scopeid/scopename to zoneid/clusterid/accounti= d/storagepoolid Added fixes for the bugs CLOUDSTACK-2176, CLOUDSTACK-2198. Description ------- CLOUDSTACK-741: Granular Global Parameters Adding the zone, cluster, account level parameters: zone: network.throttling.rate, Guest Domain Prefix cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.alloc= ated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disa= blethreshold, cluster.memory.allocated.capacity.notificationthreshold account: allow.public.user.templates, remote.access.vpn.client.iprange = This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198 and CLOUDSTACK-741. Diffs (updated) ----- api/src/com/cloud/configuration/ConfigurationService.java 6937d0b = api/src/com/cloud/network/NetworkModel.java 4d7d714 = api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java= 9f34405 = api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java = 074c5a3 = api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176= c47a = server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 = server/src/com/cloud/api/ApiDBUtils.java 21ce63b = server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 = server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 = server/src/com/cloud/configuration/Config.java dbcbc53 = server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba = server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d = server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 = server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 = server/src/com/cloud/network/NetworkModelImpl.java c5930d9 = server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 = server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a = server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce = server/src/com/cloud/server/ManagementServerImpl.java 16127a2 = server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e = server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 = server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 = server/test/com/cloud/network/MockNetworkModelImpl.java 511249f = server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 = server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 = server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.j= ava fb29469 = server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.= java f1163ef = setup/db/db/schema-410to420.sql 78444fd = test/integration/smoke/test_global_settings.py 12b35d7 = Diff: https://reviews.apache.org/r/10740/diff/ Testing ------- Thanks, Harikrishna Patnala --===============4331300492495442145==--