Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8154610860 for ; Thu, 25 Apr 2013 23:58:09 +0000 (UTC) Received: (qmail 72671 invoked by uid 500); 25 Apr 2013 23:58:08 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 72603 invoked by uid 500); 25 Apr 2013 23:58:08 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 72573 invoked by uid 500); 25 Apr 2013 23:58:08 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 72567 invoked by uid 99); 25 Apr 2013 23:58:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2013 23:58:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B77571C9101; Thu, 25 Apr 2013 23:58:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5391535210136102336==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-2196 and CLOUDSTACK-2126: fix missing async job status in listXXX api and incorrect async job status in other async api. From: "Chip Childers" To: "Chip Childers" Cc: "cloudstack" , "Min Chen" Date: Thu, 25 Apr 2013 23:58:04 -0000 Message-ID: <20130425235804.22548.63967@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chip Childers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10789/ X-Sender: "Chip Childers" References: <20130425232133.22503.221@reviews.apache.org> In-Reply-To: <20130425232133.22503.221@reviews.apache.org> Reply-To: "Chip Childers" --===============5391535210136102336== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10789/#review19743 ----------------------------------------------------------- Ship it! Applied to 4.1. Please be sure to move to master. commit 6dbf3e7b35f92eadbe6f47a8df9e465a8373d7ac Author: Min Chen Date: Thu Apr 25 16:16:13 2013 -0700 CLOUDSTACK-2196 and CLOUDSTACK-2126: fix missing async job status in li= stXXX api and incorrect async job status in other async api. - Chip Childers On April 25, 2013, 11:21 p.m., Min Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10789/ > ----------------------------------------------------------- > = > (Updated April 25, 2013, 11:21 p.m.) > = > = > Review request for cloudstack and Chip Childers. > = > = > Description > ------- > = > This patch fixed both CLOUDSTACK-2196 and CLOUDSTACK-2126. > = > = > This addresses bugs CLOUDSTACK-2126 and CLOUDSTACK-2196. > = > = > Diffs > ----- > = > core/src/com/cloud/async/AsyncJobVO.java ad482b0 = > server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 22b807c = > server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java 488c4e4 = > server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 1adff40 = > server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 3e579c= 1 = > server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 66aecc2 = > server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java 7072324 = > server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 8b6abf8 = > server/src/com/cloud/api/query/dao/VolumeJoinDaoImpl.java 495c0eb = > server/src/com/cloud/api/query/vo/AccountJoinVO.java 6d37f4d = > server/src/com/cloud/api/query/vo/DomainRouterJoinVO.java b04120a = > server/src/com/cloud/api/query/vo/HostJoinVO.java 0b8f672 = > server/src/com/cloud/api/query/vo/SecurityGroupJoinVO.java 922e130 = > server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java 89e79e5 = > server/src/com/cloud/api/query/vo/UserAccountJoinVO.java 44637db = > server/src/com/cloud/api/query/vo/UserVmJoinVO.java 33c49cd = > server/src/com/cloud/api/query/vo/VolumeJoinVO.java 4f6b35b = > = > Diff: https://reviews.apache.org/r/10789/diff/ > = > = > Testing > ------- > = > Tested locally using devcloud. > = > = > Thanks, > = > Min Chen > = > --===============5391535210136102336==--