Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A320CF8AE for ; Thu, 25 Apr 2013 04:52:55 +0000 (UTC) Received: (qmail 4858 invoked by uid 500); 25 Apr 2013 04:52:55 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 4758 invoked by uid 500); 25 Apr 2013 04:52:54 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 4741 invoked by uid 500); 25 Apr 2013 04:52:54 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 4720 invoked by uid 99); 25 Apr 2013 04:52:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2013 04:52:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C0C8C1C8F65; Thu, 25 Apr 2013 04:52:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4329437854027511213==" MIME-Version: 1.0 Subject: Re: Review Request: Don't do KVM heartbeat on secondary storage sources, primary only From: "Marcus Sorensen" To: "Chip Childers" Cc: "Marcus Sorensen" , "cloudstack" , "edison su" Date: Thu, 25 Apr 2013 04:52:50 -0000 Message-ID: <20130425045250.22548.14230@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Marcus Sorensen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10766/ X-Sender: "Marcus Sorensen" References: <20130425045142.22548.24589@reviews.apache.org> In-Reply-To: <20130425045142.22548.24589@reviews.apache.org> Reply-To: "Marcus Sorensen" --===============4329437854027511213== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10766/ ----------------------------------------------------------- (Updated April 25, 2013, 4:52 a.m.) Review request for cloudstack and Chip Childers. Changes ------- updated summary to reflect adjustment in patch Summary (updated) ----------------- Don't do KVM heartbeat on secondary storage sources, primary only Description ------- the KVM HA runner uses any NFS secondary storage resource available to a ho= st to store it's HA data. This causes template deletes to fail because it c= annot delete KVMHA, which is a directory that is not empty. So if KVMHA dir= ectory is found, delete it's contents before trying to delete it. This addresses bug CLOUDSTACK-2173. Diffs ----- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMHAMonito= r.java d1470d6 = plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePo= olManager.java c2bfad9 = Diff: https://reviews.apache.org/r/10766/diff/ Testing ------- diff revision 2 was tested with a new 4.1 zone deployment. Verified bug was= reproducable with 4.1 HEAD, applied patch, ran through adding two NFS prim= ary storages, verified KVM heartbeat was working on them, then ran various = secondary storage operations (register template, download volume, take snap= shot) and verified that they worked, and that KVM heartbeat operations were= NOT acting on them. Thanks, Marcus Sorensen --===============4329437854027511213==--