Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 77251F555 for ; Wed, 24 Apr 2013 21:30:26 +0000 (UTC) Received: (qmail 75303 invoked by uid 500); 24 Apr 2013 21:30:25 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 75262 invoked by uid 500); 24 Apr 2013 21:30:25 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 75252 invoked by uid 500); 24 Apr 2013 21:30:25 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 75243 invoked by uid 99); 24 Apr 2013 21:30:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Apr 2013 21:30:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 770961C8ED5; Wed, 24 Apr 2013 21:30:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4553417317762360180==" MIME-Version: 1.0 Subject: Re: Review Request: When associating an IP to a VPC allow admin's to specify what IP they want to associate. (CLOUDSTACK-1942) From: "Marcus Sorensen" To: "Marcus Sorensen" , "Prasanna Santhanam" , "Chiradeep Vittal" Cc: "cloudstack" , "Ryan Dietrich" Date: Wed, 24 Apr 2013 21:30:22 -0000 Message-ID: <20130424213022.22503.81331@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Marcus Sorensen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10423/ X-Sender: "Marcus Sorensen" References: <20130412161238.26514.74079@reviews.apache.org> In-Reply-To: <20130412161238.26514.74079@reviews.apache.org> Reply-To: "Marcus Sorensen" --===============4553417317762360180== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10423/#review19667 ----------------------------------------------------------- Ship it! This looks reasonable to me. Anyone else? - Marcus Sorensen On April 12, 2013, 4:12 p.m., Ryan Dietrich wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10423/ > ----------------------------------------------------------- > = > (Updated April 12, 2013, 4:12 p.m.) > = > = > Review request for cloudstack, Prasanna Santhanam, Chiradeep Vittal, and = Marcus Sorensen. > = > = > Description > ------- > = > https://issues.apache.org/jira/browse/CLOUDSTACK-1942 > = > This patch will allow you to specify an IP when associating an IP to a VP= C. > = > = > Diffs > ----- > = > api/src/com/cloud/network/NetworkService.java ab6d7bf = > api/src/org/apache/cloudstack/api/command/user/address/AssociateIPAddrC= md.java 406f782 = > server/src/com/cloud/network/NetworkManager.java 4af716c = > server/src/com/cloud/network/NetworkManagerImpl.java a97f2ce = > server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c = > server/test/com/cloud/network/MockNetworkManagerImpl.java 18eae08 = > server/test/com/cloud/vpc/MockNetworkManagerImpl.java bd4fd67 = > = > Diff: https://reviews.apache.org/r/10423/diff/ > = > = > Testing > ------- > = > Manually tested using master branch, as well as 4.1. Tested manually usi= ng "ipid" as well as leaving it off resulting in existing functionality. > = > Also, ran new marvin test. This probably could have been incorporated in= to the the existing test_network.py file, but half of those tests were fail= ing on my system. > = > = > Thanks, > = > Ryan Dietrich > = > --===============4553417317762360180==--