Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 03E38F20E for ; Wed, 24 Apr 2013 05:43:14 +0000 (UTC) Received: (qmail 3377 invoked by uid 500); 24 Apr 2013 05:43:13 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 3176 invoked by uid 500); 24 Apr 2013 05:43:12 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 3137 invoked by uid 500); 24 Apr 2013 05:43:11 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 3124 invoked by uid 99); 24 Apr 2013 05:43:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Apr 2013 05:43:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 935D11C8D26; Wed, 24 Apr 2013 05:43:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7622801432460975712==" MIME-Version: 1.0 Subject: Re: Review Request: Updated the user permission to acquire ip From: "Murali Reddy" To: "Abhinandan Prateek" , "Murali Reddy" Cc: "cloudstack" , "Jayapal Reddy" Date: Wed, 24 Apr 2013 05:43:07 -0000 Message-ID: <20130424054307.22548.66065@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Murali Reddy" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10727/ X-Sender: "Murali Reddy" References: <20130423105546.22548.54968@reviews.apache.org> In-Reply-To: <20130423105546.22548.54968@reviews.apache.org> Reply-To: "Murali Reddy" --===============7622801432460975712== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10727/#review19616 ----------------------------------------------------------- server/src/com/cloud/network/NetworkServiceImpl.java you need to check for both 'isolated' & 'shared' networks of advanced z= one. server/src/com/cloud/network/NetworkServiceImpl.java You need to check for only basic zone here. 'shared' network of advance= d zone is different from 'shared' network of basic zone w.r.t to guest IP a= llocation. server/src/com/cloud/network/NetworkServiceImpl.java this check is required, dont remove it. server/src/com/cloud/network/NetworkServiceImpl.java This check needs to be done for both advanced/basic zones and isolate/s= hared networks. = also you need to check if NIC is owned/usable by caller. No need for ch= eck access on VM - Murali Reddy On April 23, 2013, 10:55 a.m., Jayapal Reddy wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10727/ > ----------------------------------------------------------- > = > (Updated April 23, 2013, 10:55 a.m.) > = > = > Review request for cloudstack, Abhinandan Prateek and Murali Reddy. > = > = > Description > ------- > = > Updated the user permissions check > = > = > This addresses bug CLOUDSTACK-2134. > = > = > Diffs > ----- > = > server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45 = > = > Diff: https://reviews.apache.org/r/10727/diff/ > = > = > Testing > ------- > = > Unit tested on basic and advanced zone > = > = > Thanks, > = > Jayapal Reddy > = > --===============7622801432460975712==--