Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============3382736112441766352=="
MIME-Version: 1.0
Subject: Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be
 notified VM
 migration.
From: "Chiradeep Vittal" <chiradeepv@gmail.com>
To: "Chiradeep Vittal" <chiradeepv@gmail.com>,
 "Hugo Trippaers" <htrippaers@schubergphilis.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Hiroaki Kawai" <kawai@stratosphere.co.jp>
Date: Fri, 19 Apr 2013 02:21:45 -0000
Message-ID: <20130419022145.4549.57851@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Chiradeep Vittal" <noreply@reviews.apache.org>
References: <20130418224543.4549.45821@reviews.apache.org>
In-Reply-To: <20130418224543.4549.45821@reviews.apache.org>
Reply-To: "Chiradeep Vittal" <chiradeepv@gmail.com>

--===============3382736112441766352==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On April 18, 2013, 10:45 p.m., Chiradeep Vittal wrote:
> > Looks good.  Is this the final?
> =

> Hiroaki Kawai wrote:
>     Yes. :-)
>     =

>     Ready to ship? Any comments from anybody else?

Any tests?


- Chiradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9871/#review19414
-----------------------------------------------------------


On April 11, 2013, 7:22 a.m., Hiroaki Kawai wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9871/
> -----------------------------------------------------------
> =

> (Updated April 11, 2013, 7:22 a.m.)
> =

> =

> Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.
> =

> =

> Description
> -------
> =

> The location of the virtual machine is provided by DeployDestination, whi=
ch will be passed in NetworkGuru#reserve and NetworkElement#prepare. =

> =

> During the virtual machine migration, it actually changes DeployDestinati=
on and it looks like that it will tell that event to network components as =
it has NetworkManager#prepareNicForMigration. The problem is that althogh t=
he interface has that method, NetworkManagerImpl does not tell the DeployDe=
stination changes to network components. =

> =

> So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#p=
repare in NetworkManagerImpl#prepareNicForMigration . And then, we also nee=
d to add calls NetworkGuru#release and NetworkElement#release after the mig=
ration, otherwise the network resources that plugin reserved will be kept e=
ven when the vm leaves off.
> =

> Created a first minimum patch to show the concept.
> =

> =

> This addresses bug CLOUDSTACK-1638.
> =

> =

> Diffs
> -----
> =

>   api/src/com/cloud/network/NetworkMigrationResponder.java PRE-CREATION =

>   server/src/com/cloud/network/NetworkManager.java 4124b19 =

>   server/src/com/cloud/network/NetworkManagerImpl.java a98bdd4 =

>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 9230f4a =

> =

> Diff: https://reviews.apache.org/r/9871/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Hiroaki Kawai
> =

>


--===============3382736112441766352==--