Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C6D5F5A5 for ; Fri, 12 Apr 2013 12:58:55 +0000 (UTC) Received: (qmail 82632 invoked by uid 500); 12 Apr 2013 12:58:54 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 82557 invoked by uid 500); 12 Apr 2013 12:58:54 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 82544 invoked by uid 500); 12 Apr 2013 12:58:54 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 82534 invoked by uid 99); 12 Apr 2013 12:58:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2013 12:58:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 935291C84CE; Fri, 12 Apr 2013 12:58:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5514815120249696178==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-1989 From: "Chip Childers" To: "Marcus Sorensen" , "Chip Childers" Cc: "cloudstack" , "Min Chen" , "Ryan Dietrich" Date: Fri, 12 Apr 2013 12:58:50 -0000 Message-ID: <20130412125850.13808.65363@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chip Childers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10426/ X-Sender: "Chip Childers" References: <20130412045734.13808.61053@reviews.apache.org> In-Reply-To: <20130412045734.13808.61053@reviews.apache.org> Reply-To: "Chip Childers" --===============5514815120249696178== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10426/ ----------------------------------------------------------- (Updated April 12, 2013, 12:58 p.m.) Review request for cloudstack, Chip Childers and Marcus Sorensen. Summary (updated) ----------------- Fix for CLOUDSTACK-1989 Description ------- So, without this fix you can't query service offerings that don't have a do= main id set (null). This addresses bug CLOUDSTACK-1989. Diffs ----- server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e = Diff: https://reviews.apache.org/r/10426/diff/ Testing ------- Called "listServiceOfferings" using a simple perl script, once with an ID, = and once without an ID specified. Thanks, Ryan Dietrich --===============5514815120249696178==--