Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6EBF10583 for ; Fri, 12 Apr 2013 10:06:14 +0000 (UTC) Received: (qmail 22344 invoked by uid 500); 12 Apr 2013 10:06:14 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 22276 invoked by uid 500); 12 Apr 2013 10:06:14 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 22265 invoked by uid 500); 12 Apr 2013 10:06:14 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 22254 invoked by uid 99); 12 Apr 2013 10:06:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2013 10:06:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ACCED1C10E3; Fri, 12 Apr 2013 10:06:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3426528837109269737==" MIME-Version: 1.0 Subject: Re: Review Request: Cloudstack-1534 Disable/Enable-unmanage/manage cluster is setting CPU overcommit and Memory overcommit ratio to 1(default value) From: "Abhinandan Prateek" To: "Abhinandan Prateek" Cc: "cloudstack" , "bharat kumar" Date: Fri, 12 Apr 2013 10:06:11 -0000 Message-ID: <20130412100611.13837.56066@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abhinandan Prateek" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10368/ X-Sender: "Abhinandan Prateek" References: <20130412095914.26514.31158@reviews.apache.org> In-Reply-To: <20130412095914.26514.31158@reviews.apache.org> Reply-To: "Abhinandan Prateek" --===============3426528837109269737== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 12, 2013, 9:59 a.m., Abhinandan Prateek wrote: > > Ship It! committed - Abhinandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10368/#review19062 ----------------------------------------------------------- On April 9, 2013, 11:13 a.m., bharat kumar wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10368/ > ----------------------------------------------------------- > = > (Updated April 9, 2013, 11:13 a.m.) > = > = > Review request for cloudstack and Abhinandan Prateek. > = > = > Description > ------- > = > Cloudstack-1534 Disable/Enable-unmanage/manage cluster is setting CPU ove= rcommit and Memory overcommit ratio to 1(default value) > = > = > This addresses bug CLOUDSTACK-1534. > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCm= d.java 95728dd = > server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51 = > = > Diff: https://reviews.apache.org/r/10368/diff/ > = > = > Testing > ------- > = > tested on master. > = > = > Thanks, > = > bharat kumar > = > --===============3426528837109269737==--