Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F33F10FF3 for ; Fri, 12 Apr 2013 05:28:40 +0000 (UTC) Received: (qmail 74429 invoked by uid 500); 12 Apr 2013 05:28:40 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 74280 invoked by uid 500); 12 Apr 2013 05:28:39 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 74271 invoked by uid 500); 12 Apr 2013 05:28:39 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 74253 invoked by uid 99); 12 Apr 2013 05:28:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2013 05:28:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0CE671C8477; Fri, 12 Apr 2013 05:28:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9041026401964394671==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-1987 From: "Min Chen" To: "Marcus Sorensen" , "Chip Childers" Cc: "cloudstack" , "Min Chen" , "Ryan Dietrich" Date: Fri, 12 Apr 2013 05:28:37 -0000 Message-ID: <20130412052837.13808.15206@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Min Chen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10426/ X-Sender: "Min Chen" References: <20130412045734.13808.61053@reviews.apache.org> In-Reply-To: <20130412045734.13808.61053@reviews.apache.org> Reply-To: "Min Chen" --===============9041026401964394671== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10426/#review19052 ----------------------------------------------------------- server/src/com/cloud/api/query/QueryManagerImpl.java For domain users, they should not be able to query system offerings. Th= is fix didn't guard that case. - Min Chen On April 12, 2013, 4:57 a.m., Ryan Dietrich wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10426/ > ----------------------------------------------------------- > = > (Updated April 12, 2013, 4:57 a.m.) > = > = > Review request for cloudstack, Chip Childers and Marcus Sorensen. > = > = > Description > ------- > = > So, without this fix you can't query service offerings that don't have a = domain id set (null). > = > = > Diffs > ----- > = > server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e = > = > Diff: https://reviews.apache.org/r/10426/diff/ > = > = > Testing > ------- > = > Called "listServiceOfferings" using a simple perl script, once with an ID= , and once without an ID specified. > = > = > Thanks, > = > Ryan Dietrich > = > --===============9041026401964394671==--