Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95127F453 for ; Mon, 8 Apr 2013 13:48:01 +0000 (UTC) Received: (qmail 90009 invoked by uid 500); 8 Apr 2013 13:48:01 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 89889 invoked by uid 500); 8 Apr 2013 13:48:00 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 89475 invoked by uid 500); 8 Apr 2013 13:48:00 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 89453 invoked by uid 99); 8 Apr 2013 13:47:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Apr 2013 13:47:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 192D31C1977; Mon, 8 Apr 2013 13:47:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0873338981360907925==" MIME-Version: 1.0 Subject: Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly From: "Chip Childers" To: "Chip Childers" Cc: "cloudstack" , "Kelven Yang" Date: Mon, 08 Apr 2013 13:47:56 -0000 Message-ID: <20130408134756.13808.93898@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chip Childers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10292/ X-Sender: "Chip Childers" References: <20130404221403.23853.4706@reviews.apache.org> In-Reply-To: <20130404221403.23853.4706@reviews.apache.org> Reply-To: "Chip Childers" --===============0873338981360907925== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10292/#review18776 ----------------------------------------------------------- This appears to have already been applied to 4.1. - Chip Childers On April 4, 2013, 10:14 p.m., Kelven Yang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10292/ > ----------------------------------------------------------- > = > (Updated April 4, 2013, 10:14 p.m.) > = > = > Review request for cloudstack and Chip Childers. > = > = > Description > ------- > = > With removal of component auto-scanning, all components are needed to con= figure in XML files. For OSS deployment, component declarations will be in = applicationContext.xml and componentContext.xml, for non-OSS deployment, co= mponent declarations will be in applicationContext.xml and nonossComponentC= ontext.xml > = > OSS/non-OSS common components should all go to applicationContext.xml, OS= S or non-OSS specific components, or if there are OSS or non-OSS specific a= dapter configurations, they should go to componentContext.xml or nonCompone= ntContext.xml respecitively. > = > If you add a big feature module, organize all components for the module i= nto its own section. = > = > = > This addresses bug CLOUDSTACK-1917. > = > = > Diffs > ----- > = > client/tomcatconf/applicationContext.xml.in 17725f0 = > client/tomcatconf/componentContext.xml.in 2a4a29f = > client/tomcatconf/nonossComponentContext.xml.in 13004c3 = > utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION = > = > Diff: https://reviews.apache.org/r/10292/diff/ > = > = > Testing > ------- > = > manual test is done for both OSS/non-OSS > = > = > Thanks, > = > Kelven Yang > = > --===============0873338981360907925==--