Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 365D7F0A6 for ; Mon, 1 Apr 2013 22:43:19 +0000 (UTC) Received: (qmail 884 invoked by uid 500); 1 Apr 2013 22:43:18 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 815 invoked by uid 500); 1 Apr 2013 22:43:18 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 724 invoked by uid 500); 1 Apr 2013 22:43:18 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 692 invoked by uid 99); 1 Apr 2013 22:43:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Apr 2013 22:43:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0476B1C5EB1; Mon, 1 Apr 2013 22:43:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2784091075268687754==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-922: LXC Support in Cloudstack From: "edison su" To: "edison su" , akarasulu@apache.org Cc: "cloudstack" , "Phong Nguyen" Date: Mon, 01 Apr 2013 22:43:16 -0000 Message-ID: <20130401224316.23824.58586@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "edison su" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10122/ X-Sender: "edison su" References: <20130326210207.12496.90410@reviews.apache.org> In-Reply-To: <20130326210207.12496.90410@reviews.apache.org> Reply-To: "edison su" --===============2784091075268687754== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10122/#review18604 ----------------------------------------------------------- Ship it! Ship It! - edison su On March 26, 2013, 9:02 p.m., Phong Nguyen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10122/ > ----------------------------------------------------------- > = > (Updated March 26, 2013, 9:02 p.m.) > = > = > Review request for cloudstack, akarasulu and edison su. > = > = > Description > ------- > = > This is a patch for adding LXC support to Cloudstack. > = > Please see the following links for more details: > = > Design doc: https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Su= pport+in+Cloudstack > Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-922 > = > = > Diffs > ----- > = > agent/conf/agent.properties f7eac67 = > api/src/com/cloud/agent/api/Command.java 9cd6749 = > api/src/com/cloud/agent/api/RebootCommand.java 299e61b = > api/src/com/cloud/agent/api/StopCommand.java 9ee7ce3 = > api/src/com/cloud/hypervisor/Hypervisor.java 2e0012d = > api/src/com/cloud/storage/Storage.java fba12b6 = > client/tomcatconf/componentContext.xml.in a98a41f = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/DirectVif= Driver.java PRE-CREATION = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtCo= mputingResource.java 8ee3ea4 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtCo= nnection.java 981d343 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDo= mainXMLParser.java b622b6d = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtSt= orageVolumeDef.java d5cd91a = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVM= Def.java c93aeeb = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMPhysica= lDisk.java 08f51a4 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorage= PoolManager.java c2bfad9 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtSto= rageAdaptor.java d5e6ad6 = > plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtV= MDefTest.java b723875 = > scripts/storage/secondary/cloud-install-sys-tmplt 2172b28 = > server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 544a803 = > server/src/com/cloud/hypervisor/LXCGuru.java PRE-CREATION = > server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java= 75e00ad = > server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.= java PRE-CREATION = > server/src/com/cloud/hypervisor/kvm/discoverer/LxcServerDiscoverer.java= PRE-CREATION = > server/src/com/cloud/network/SshKeysDistriMonitor.java fc7c882 = > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.= java 6742f7b = > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java= 46ac7af = > server/src/com/cloud/template/HypervisorTemplateAdapter.java 1426421 = > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 0aeef0e = > setup/db/db/schema-410to420.sql eb650cc = > ui/scripts/system.js c0a5d14 = > ui/scripts/templates.js 040ce4a = > ui/scripts/zoneWizard.js 5108c5c = > = > Diff: https://reviews.apache.org/r/10122/diff/ > = > = > Testing > ------- > = > Performed end-to-end testing for starting an LXC instance: > = > - Add an LXC cluster > - Add an LXC host > - Register an LXC template > - Spin up an LXC container > = > Additional testing: > = > - Verified connectivity with direct network settings > - Used KVM systemvm with LXC cluster > = > = > Thanks, > = > Phong Nguyen > = > --===============2784091075268687754==--