cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Musayev, Ilya" <imusa...@webmd.net>
Subject RE: Review Request: CLOUDSTACK-2053: Fix bash if/else logic to avoid redundant entries in htaccess file, fixed boto/cloud-init support by adding metadata RewriteRules
Date Fri, 19 Apr 2013 19:23:14 GMT
I wonder what I'm doing wrong.

I've attempted to submit a second patch to address Chiradeeps comment, use Update Diff, placed
parent and child diffs, and review board - died yet again.


> -----Original Message-----
> From: ilya musayev [mailto:noreply@reviews.apache.org] On Behalf Of ilya
> musayev
> Sent: Friday, April 19, 2013 2:10 PM
> To: Chiradeep Vittal
> Cc: ilya musayev; cloudstack
> Subject: Re: Review Request: CLOUDSTACK-2053: Fix bash if/else logic to
> avoid redundant entries in htaccess file, fixed boto/cloud-init support by
> adding metadata RewriteRules
> 
> 
> 
> > On April 18, 2013, 11:36 p.m., Chiradeep Vittal wrote:
> > > patches/systemvm/debian/config/root/userdata.sh, line 79
> > > <https://reviews.apache.org/r/10614/diff/1/?file=282479#file282479li
> > > ne79>
> > >
> > >     why is this needed? shouldn't the first rewrite rule be sufficient?
> > >
> 
> See comments above.
> 
> 
> - ilya
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10614/#review19416
> -----------------------------------------------------------
> 
> 
> On April 18, 2013, 11:02 p.m., ilya musayev wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10614/
> > -----------------------------------------------------------
> >
> > (Updated April 18, 2013, 11:02 p.m.)
> >
> >
> > Review request for cloudstack and Chiradeep Vittal.
> >
> >
> > Description
> > -------
> >
> > Addressed 2 issues:
> > Rewrote the bash if/else check to fix redundant entries Added
> > RewriteRules to support boto/cloud-init - as per Chiradeep - this
> > would only affect VMWare deployments, as this userdata.sh script is
> > only used with vmware system router vms
> >
> >
> > This addresses bug CLOUDSTACK-2053.
> >
> >
> > Diffs
> > -----
> >
> >   patches/systemvm/debian/config/root/userdata.sh e5d170b
> >
> > Diff: https://reviews.apache.org/r/10614/diff/
> >
> >
> > Testing
> > -------
> >
> > ACS4.1
> >
> >
> > Thanks,
> >
> > ilya musayev
> >
> >

Mime
View raw message