cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Noah Slater <nsla...@apache.org>
Subject [DISCUSS] Enable GitHub pull request notification (Was: Re: GitHub pull requests (Was: Re: Github integration))
Date Sat, 27 Apr 2013 16:35:23 GMT
Devs,

I would like to propose that we turn on notifications for pull requests
that are made via GitHub. This will ensure that PRs are not "lost between
the cracks". I believe this integration is already available, and we just
need to request it.

You do not need to respond if you are in agreement. If there is no response
in 72 hours, I will assume lazy consensus.

If we reach consensus, I will start the corresponding [VOTE] thread and
complete the rest of process.

(Please note that when I brought this up originally, the idea had a +1 from
Prasanna and Rohit. But I do not believe I stated lazy consensus  So I am
doing this a second time, properly. Sorry about that folks!)

Thanks,

On 7 October 2012 03:03, Noah Slater <nslater@tumbolia.org> wrote:

> I've been talking with Paul Davis about how we can fix this situation. But
> no, at the moment, you cannot merge them directly in GitHub. However, while
> we might advocate RB as the preferred way to submit patches, I do not think
> we should "lock out" people who prefer to work within the confines of
> GitHub. This question is not just about "should we get notifications sent".
> It is more about "should we open this up as a supported channel for
> receiving contributions?"
>
>
> On Sun, Oct 7, 2012 at 1:59 AM, Brett Porter <brett@apache.org> wrote:
>
>>
>> On 30/09/2012, at 2:31 AM, Noah Slater <nslater@tumbolia.org> wrote:
>>
>> > Breaking off this question:
>> >
>> > On Sat, Sep 29, 2012 at 3:50 PM, Donal Lafferty
>> > <donal.lafferty@citrix.com>wrote:
>> >
>> >>
>> >> WRT emails for all GIT pulls, wouldn't broadcasting pull requests
>> clutter
>> >> the dev mailing list?
>> >
>> >
>> > No, I don't think so.
>> >
>> > A GitHub pull request is the same as someone coming to the list and
>> asking
>> > us to apply a patch.
>> >
>> > If they become a nuisance (what a wonderful problem to have!) we could
>> > funnel them elsewhere.
>> >
>> > PR integration on GitHub will attract a broader base of contributions
>> from
>> > the community.
>> >
>>
>> My understanding of the current pull request integration is that
>> notifications can be sent to the list, but can not be closed or interacted
>> with on github (other than requesting the original reporter to close them,
>> or an administrator) - so it's not really integration as much as avoiding
>> it slipping through the cracks when someone finds the github repo. Is that
>> still the case?
>>
>> Particularly with review board in place, it would seem like getting
>> notifications of PRs is a good idea, but explicitly encouraging their use
>> is not.
>>
>> - Brett
>>
>>
>>
>
>
> --
> NS
>



-- 
NS

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message