cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus Sorensen <shadow...@gmail.com>
Subject Re: Review Request: Fix for CLOUDSTACK-1987
Date Fri, 12 Apr 2013 04:55:57 GMT
Adding list, it looks like reviews.apache.org left it off (due to the group
field being empty?).


On Thu, Apr 11, 2013 at 10:53 PM, Marcus Sorensen <shadowsor@gmail.com>wrote:

> There were two issues, one is that  service offerings that have been
> deleted show up as available from a domain user's perspective (but not as
> root admin), that's CLOUDSTACK-1987. The other (CLOUDSTACK-1989) is that
> users can't provide an offering id to get the list info of a particular
> offering, they can query all, but if they provide an offering ID they get
> an empty list.
>
>
> On Thu, Apr 11, 2013 at 10:44 PM, Ryan Dietrich <ryan@betterservers.com>wrote:
>
>> This fix solves a related problem.   (Marcus, I thought this was Scott's
>> issue)
>>
>> Right now, domain users cannot query service offerings by ID's.
>> Should I file a different bug then?
>>
>> It's pretty simple to replicate.  As a domain user, call
>> listServiceOfferings, then make the same call with an ID of a system wide
>> offering.
>>
>> On Apr 11, 2013, at 7:06 PM, Min Chen <min.chen@citrix.com> wrote:
>>
>>    This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10426/
>>    server/src/com/cloud/api/query/QueryManagerImpl.java<https://reviews.apache.org/r/10426/diff/1/?file=280571#file280571line2110>
(Diff
>> revision 1)
>>
>> {'text': 'public class QueryManagerImpl extends ManagerBase implements QueryService
{', 'line': 153, 'expand_offset': 1950}
>>
>>     2110
>>
>>             spc.addOr("domainId", SearchCriteria.Op.IN, domainIds.toArray());
>>
>>   Somehow I could not understand how this addresses CLOUDSTACK-1987? Are you saying
that if a service offering is deleted, its domain id is set to NULL? Did I overlook something
here?
>>
>>
>> - Min
>>
>> On April 11th, 2013, 11:43 p.m., Ryan Dietrich wrote:
>>   Review request for Chip Childers and Marcus Sorensen.
>> By Ryan Dietrich.
>>
>> *Updated April 11, 2013, 11:43 p.m.*
>> Description
>>
>> So, without this fix you can't query service offerings that don't have a domain id
set (null).
>>
>>   Testing
>>
>> Called "listServiceOfferings" using a simple perl script, once with an ID, and once
without an ID specified.
>>
>>   Diffs
>>
>>    - server/src/com/cloud/api/query/QueryManagerImpl.java (951d09e)
>>
>> View Diff <https://reviews.apache.org/r/10426/diff/>
>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message