cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Likitha Shetty <likitha.she...@citrix.com>
Subject RE: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Date Mon, 08 Apr 2013 23:46:02 GMT
Yes, we don't allow admin to shrink a guest VLAN range. The 2 scenarios I mentioned are negative
test cases that need to be handled.

Thank you,
Likitha

>-----Original Message-----
>From: Pranav Saxena
>Sent: Monday, April 08, 2013 4:35 PM
>To: dev@cloudstack.apache.org; Likitha Shetty; Abhinandan Prateek
>Cc: cloudstack; Bharat Kumar
>Subject: RE: Review Request: Cloudstack-701 Support for non contiguous vlan
>ranges.
>
>The FS says that the feature only deals with extending the VLAN range when
>calling the update physical network API with the new VLAN range parameter . So
>, why would shrinking a VLAN range be a valid use case for it ? When you have
>already given a VLAN Range which when gets exhausted calls the need for this
>feature perhaps. I might not be 100 % correct but this is what I remember about
>the discussion I had with Abhi and Bharat .
>
>-----Original Message-----
>From: Likitha Shetty [mailto:noreply@reviews.apache.org] On Behalf Of Likitha
>Shetty
>Sent: Tuesday, April 09, 2013 3:06 AM
>To: Abhinandan Prateek
>Cc: cloudstack; Bharat Kumar; Likitha Shetty
>Subject: Re: Review Request: Cloudstack-701 Support for non contiguous vlan
>ranges.
>
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/10238/#review18795
>-----------------------------------------------------------
>
>
>
>server/src/com/cloud/network/NetworkServiceImpl.java
><https://reviews.apache.org/r/10238/#comment39235>
>
>    Please handle the following 2 corner cases where admin user tries to shrink
>the existing vnet ranges
>    1. New start vnet is equal to the start vnet of the existing range and the new
>end vnet is less than the existing end vnet
>    2. New start vnet is greater than the start vnet of the existing range and the
>new end vnet is equal to the existing end vnet
>
>
>- Likitha Shetty
>
>
>On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10238/
>> -----------------------------------------------------------
>>
>> (Updated April 4, 2013, 12:36 p.m.)
>>
>>
>> Review request for cloudstack and Abhinandan Prateek.
>>
>>
>> Description
>> -------
>>
>> Cloudstack-701: Support for non contiguous vlan ranges.
>>
>>
>> Diffs
>> -----
>>
>>   api/src/com/cloud/network/NetworkService.java ab6d7bf
>>   api/src/com/cloud/network/PhysicalNetwork.java a2044a6
>>   api/src/org/apache/cloudstack/api/ApiConstants.java c518830
>>
>api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNe
>tworkCmd.java 06cf38d
>>   server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
>>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
>>   server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
>>   server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
>>   server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java
>ae00bf2
>>   server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
>>   server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
>>   server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
>>   server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
>>   server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
>>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-
>CREATION
>>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
>>   test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/10238/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested on latest master.
>>
>>
>> Thanks,
>>
>> bharat kumar
>>
>>

Mime
View raw message