cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Review Request: Fix NPE in the planner, in the case that pool ID cannot be looked up in database when deploying a VM
Date Mon, 29 Apr 2013 22:00:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10842/
-----------------------------------------------------------

Review request for cloudstack, Chip Childers and edison su.


Description
-------

This fixes a null pointer if selected pool on which to deploy is unable to be looked up via
id. Used the same coding style found in the original code (large if/else block).

If this is accepted, I'll fix master too. This patch doesn't apply cleanly, but the code is
very similar.


This addresses bug CLOUDSTACK-2281.


Diffs
-----

  server/src/com/cloud/deploy/FirstFitPlanner.java 31fc43c 

Diff: https://reviews.apache.org/r/10842/diff/


Testing
-------

Fixed broken system, tested against devcloud to ensure that it didn't break a stock/fresh
install (advanced zone with 3 storage pools). Restarted VMs to ensure that the planner still
functioned that way as well.


Thanks,

Marcus Sorensen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message