cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Review Request: CLOUDSTACK-1904: API : UI : Admin can not delete Events/Archive from other accounts
Date Fri, 26 Apr 2013 11:26:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10796/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.


Description
-------

CLOUDSTACK-1904: API : UI : Admin can not delete Events/Archive from other accounts.


This addresses bug CLOUDSTACK-1904.


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java 55ca92a 
  core/src/com/cloud/event/dao/EventDao.java da5f47a 
  core/src/com/cloud/event/dao/EventDaoImpl.java 6ba59c5 
  server/src/com/cloud/domain/dao/DomainDao.java afeb0f4 
  server/src/com/cloud/domain/dao/DomainDaoImpl.java c30ca5e 
  server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
  server/src/com/cloud/user/dao/AccountDao.java 3b7fa66 
  server/src/com/cloud/user/dao/AccountDaoImpl.java 892fdcd 
  server/test/com/cloud/event/EventControlsUnitTest.java 3c25275 

Diff: https://reviews.apache.org/r/10796/diff/


Testing
-------

Tests:
1. Create a domain.
2. Create an admin account (a11) under this domain.
3. Login to the domain admin account and then logout (this is to generate login/logout events).
4. Login to Root Admin account.
5. Go to Events and try to delete/archive events with account=a11 (domain admin account).
6. Event got deleted and verifies the control flow of admin accounts in CloudStack.


Thanks,

Sanjay Tripathi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message