cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request: Multiple IP Ranges Support in CloudStack
Date Fri, 26 Apr 2013 11:18:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19766
-----------------------------------------------------------



test/integration/component/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/10792/#comment40775>

    If it makes sense to combine the testcases I'd do so.  No need to bloat up the testcase
numbers. More the tests, longer the run. 
    
    But in your case I'd say include a comment explaining how this test differs from your
test. Minor nitpick. Else this can be shipped.!


- Prasanna Santhanam


On April 26, 2013, 11 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 11 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
> 
> 
> Description
> -------
> 
> Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges"
support in CloudStack.
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10792/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message