cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request: Delete KVMHA dir contents if found when deleting templates, volumes from nfs secondary storage
Date Thu, 25 Apr 2013 00:11:23 GMT


> On April 24, 2013, 11:05 p.m., edison su wrote:
> > The HA will write data into secondary storage also? It should only write data into
primary storage.
> 
> Marcus Sorensen wrote:
>     The KVMStoragePoolManager is currently adding any NFS type to the list of HA pools
to write to. I can change that as well, I'm just not very familiar with why it was working
that way in the first place. Will look at it now.

Ok, I think I know what the issue is. In 4.0, primary storage pools were created via KVMStoragePoolManager's
createStoragePool, which calls LibvirtStorageAdaptor's createStoragePool, and then adds it
to the HA list. Secondary storage shortcuts directly into LibvirtStorageAdaptor's createStoragePool,
and never gets added to the HA list. In 4.1, everything goes through KVMStoragePool so we
can identify the proper storage adaptor. I see no simple way to differentiate primary vs secondary
NFS storage from within KVMStoragePoolManager, other than the 'template/tmpl', 'volumes',
and 'snapshots' directories in their paths. We may have to pass that in.


- Marcus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10766/#review19676
-----------------------------------------------------------


On April 24, 2013, 9:23 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10766/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:23 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> the KVM HA runner uses any NFS secondary storage resource available to a host to store
it's HA data. This causes template deletes to fail because it cannot delete KVMHA, which is
a directory that is not empty. So if KVMHA directory is found, delete it's contents before
trying to delete it.
> 
> 
> This addresses bug CLOUDSTACK-2173.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java e65cbe1 
> 
> Diff: https://reviews.apache.org/r/10766/diff/
> 
> 
> Testing
> -------
> 
> Had a bunch of templates that the scavenger was failing to clean up. Applied this patch,
installed the code, and the templates all cleaned up successfully.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message