cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request: When associating an IP to a VPC allow admin's to specify what IP they want to associate. (CLOUDSTACK-1942)
Date Wed, 24 Apr 2013 21:30:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10423/#review19667
-----------------------------------------------------------

Ship it!


This looks reasonable to me. Anyone else?

- Marcus Sorensen


On April 12, 2013, 4:12 p.m., Ryan Dietrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10423/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 4:12 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, Chiradeep Vittal, and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1942
> 
> This patch will allow you to specify an IP when associating an IP to a VPC.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/NetworkService.java ab6d7bf 
>   api/src/org/apache/cloudstack/api/command/user/address/AssociateIPAddrCmd.java 406f782

>   server/src/com/cloud/network/NetworkManager.java 4af716c 
>   server/src/com/cloud/network/NetworkManagerImpl.java a97f2ce 
>   server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 18eae08 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java bd4fd67 
> 
> Diff: https://reviews.apache.org/r/10423/diff/
> 
> 
> Testing
> -------
> 
> Manually tested using master branch, as well as 4.1.  Tested manually using "ipid" as
well as leaving it off resulting in existing functionality.
> 
> Also, ran new marvin test.  This probably could have been incorporated into the the existing
test_network.py file, but half of those tests were failing on my system.
> 
> 
> Thanks,
> 
> Ryan Dietrich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message