cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request: Merging changes to marvin after ipclearance from cloudstack-qa
Date Wed, 24 Apr 2013 06:56:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10741/#review19618
-----------------------------------------------------------



tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/10741/#comment40530>

    in the absence of serviceofferingid, 
    cmd.serviceofferingid = services["serviceoffering"] might not be correct as we need to
create a service offering and pass on its id



tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/10741/#comment40529>

    I am wondering what happens in the absence of diskofferingid?
    cmd.diskofferingid = services["diskoffering"] will not be correct diskofferingid assignment.


- SrikanteswaraRao Talluri


On April 23, 2013, 9:49 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10741/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 9:49 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> Merging changes to marvin after ipclearance from cloudstack-qa
> 
> - Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
> - VPC support for existing base classes
> - Read hypervisor config from setting file
> - Support for keypair authentication in remoteSSHClient
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/asyncJobMgr.py 40304fa 
>   tools/marvin/marvin/cloudstackConnection.py 214a878 
>   tools/marvin/marvin/cloudstackTestClient.py 85552ed 
>   tools/marvin/marvin/dbConnection.py 8fa8643 
>   tools/marvin/marvin/deployDataCenter.py d358789 
>   tools/marvin/marvin/integration/lib/base.py 92cdf81 
>   tools/marvin/marvin/integration/lib/utils.py cff24a1 
>   tools/marvin/marvin/remoteSSHClient.py 4fb2f0d 
> 
> Diff: https://reviews.apache.org/r/10741/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message