cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request: updated the listnics response for non-root user
Date Wed, 24 Apr 2013 05:57:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/#review19617
-----------------------------------------------------------



server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10703/#comment40528>

    I don't think we should be passing VLAN information in NicResponse. 
    
    
    Its important that we pass network ID to which this NIC belong. I dont see network id
being set in the nic response. 


- Murali Reddy


On April 22, 2013, 11:10 a.m., Jayapal Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10703/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 11:10 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Description
> -------
> 
> Updated listnics response for normal user
> 
> 
> This addresses bug CLOUDSTACK-1573.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java a7d6165 
> 
> Diff: https://reviews.apache.org/r/10703/diff/
> 
> 
> Testing
> -------
> 
> Tested with admin and normal user
> 
> 
> Thanks,
> 
> Jayapal Reddy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message